documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Deprecation warnings on building the documentation site

Open aallan opened this issue 2 years ago • 8 comments

After the PRs for dependency updates that @mudge merged the other day I’m now getting deprecation warnings on building the documentation site.

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacing-unit, 2) or calc($spacing-unit / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
40 │   margin-bottom: $spacing-unit / 2;
   │                  ^^^^^^^^^^^^^^^^^
   ╵
    ../../../../minima-2.5.1/_sass/minima/_base.scss 40:18           @import
    minima.scss 48:3                                                 @import
    /Users/aa/Repos/documentation/build/jekyll/assets/main.scss 1:9  root stylesheet

aallan avatar Mar 02 '23 10:03 aallan

See https://github.com/jekyll/minima/issues/709

mudge avatar Mar 02 '23 10:03 mudge

Thanks for the pointer @mudge

aallan avatar Mar 02 '23 10:03 aallan

@aallan given the contents of that thread Paul linked, would you be ok with just hiding those warnings until minima ships their next release?

nelliemckesson avatar Mar 14 '23 17:03 nelliemckesson

@aallan given the contents of that thread Paul linked, would you be ok with just hiding those warnings until minima ships their next release?

Seems reasonable! 🤣

aallan avatar Mar 14 '23 18:03 aallan

This is temporarily handled by #2866 , but let's keep this issue open as a reminder to keep an eye on minima releases.

nelliemckesson avatar Mar 17 '23 16:03 nelliemckesson

Merged #2866, but we'll keep this open for a proper fix later.

aallan avatar Mar 17 '23 16:03 aallan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 21 '23 02:05 github-actions[bot]

According to the issue @mudge linked to above, this hasn't been fixed in upstream yet.

lurch avatar May 21 '23 09:05 lurch