docker icon indicating copy to clipboard operation
docker copied to clipboard

Fix links to docker hub in README.md

Open thawn opened this issue 1 year ago • 1 comments

The links to docker hub still pointed to the deprecated images. This pull request updates the links to point to the current images.

Fixes issue #661

thawn avatar Apr 25 '24 09:04 thawn

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Apr 25 '24 09:04 copy-pr-bot[bot]

Thanks very much for this! Could you also update the references in CONTRIBUTING.md?

I found those like this:

git grep -E 'rapidsai\-notebook'

jameslamb avatar May 23 '24 18:05 jameslamb

@jameslamb thanks a lot for the code review!

I made the requested changes in CONTRIBUTING.md

thawn avatar May 24 '24 13:05 thawn

Also searched myself again and did not find another occurrence of rapidsai-notebook

thawn avatar May 24 '24 13:05 thawn

thanks for the tip with git grep -E did not know that one ;-)

thawn avatar May 24 '24 13:05 thawn

Thanks for the help!

jameslamb avatar May 24 '24 13:05 jameslamb

Thanks @thawn!

raydouglass avatar May 24 '24 13:05 raydouglass

/merge

raydouglass avatar May 24 '24 13:05 raydouglass