distributed-join icon indicating copy to clipboard operation
distributed-join copied to clipboard
verified publisher icon rapidsai

Replace `cudaStreamDefault`

Open gaohao95 opened this issue 5 years ago • 2 comments

cudaStreamDefault is a flag used for passing to cudaStreamCreateWithFlags instead of a valid stream. We should replace that with either rmm::cuda_stream_default or 0.

gaohao95 avatar Dec 03 '20 17:12 gaohao95

I can't find cudaStreamCreateWithFlags in our code - did you mean that cudaStreamDefault is passed into RMM functions (allocate/deallocate), and we should replace it with rmm::cuda_stream_default?

nsakharnykh avatar Dec 03 '20 19:12 nsakharnykh

I can't find cudaStreamCreateWithFlags in our code - did you mean that cudaStreamDefault is passed into RMM functions (allocate/deallocate), and we should replace it with rmm::cuda_stream_default?

Yes. Basically we shouldn't pass cudaStreamDefault to a function that accepts cudaStream_t or rmm::cuda_stream. cudaStreamDefault is badly named in CUDA, and is not the default stream.

gaohao95 avatar Dec 03 '20 19:12 gaohao95