cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Adds option to take explicit nested schema for nested JSON reader

Open elstehle opened this issue 3 years ago • 1 comments

Description

This PR adds the option to take an explicit nested schema, allowing users to specify the target data types of the leave columns in the nested JSON reader. This PR adds the corresponding interface and implementation to libcudf.

In addition, the PR makes existing JSON reader tests parametrised tests and enables those tests for dual execution of (1) the existing JSON reader and (2) the new nested JSON reader.

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

elstehle avatar Sep 12 '22 06:09 elstehle

Codecov Report

:exclamation: No coverage uploaded for pull request base (branch-22.10@5c91739). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10   #11682   +/-   ##
===============================================
  Coverage                ?   85.90%           
===============================================
  Files                   ?      151           
  Lines                   ?    23601           
  Branches                ?        0           
===============================================
  Hits                    ?    20275           
  Misses                  ?     3326           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 19 '22 23:09 codecov[bot]

rerun tests

elstehle avatar Sep 21 '22 22:09 elstehle

@gpucibot merge

elstehle avatar Sep 22 '22 06:09 elstehle