rio icon indicating copy to clipboard operation
rio copied to clipboard
verified publisher icon raphamorim

[Bug] Noticeable text update

Open MrPandir opened this issue 1 year ago • 4 comments

When I enter docker stats I see the text update every second and the cursor momentarily jumps to the beginning. This does not happen in Apple Terminal. But this does not happen with programs that refresh the entire screen such as btop or htop and are displayed correctly.

Videos

https://github.com/raphamorim/rio/assets/137798474/230e12a5-cf14-4149-ab01-08990e7e7450

https://github.com/raphamorim/rio/assets/137798474/7005102f-51a9-4284-a99f-9c2f2c38a410

Additional Information

Rio Version: 0.0.36 OS: macOS 14.4 Config:

cursor = '▇'
blinking-cursor = false
confirm-before-quit = false
[navigation]
mode = "CollapsedTab"

MrPandir avatar Apr 23 '24 13:04 MrPandir

Hey @MrPandir, thanks for the issue.

Yes I am aware of it, should be fixed in the upcoming version of Rio (0.1.0) that does compute visual diffs before clean and redraw.

raphamorim avatar Apr 24 '24 22:04 raphamorim

This issue should not be able to reproduce with the latest release (v0.1.0) since Rio now does not compute render on the same data tree, closing this issue for now. In case find anything odd we can reopen or create a new issue.

raphamorim avatar Jun 10 '24 14:06 raphamorim

Unfortunately this was not fixed in version 0.1.0

https://github.com/raphamorim/rio/assets/137798474/a71e094c-bda4-46d3-bd51-a4d8a77ca28f

MrPandir avatar Jun 11 '24 07:06 MrPandir

Yea, I can reproduce as well. Reopening this issue.

raphamorim avatar Jun 11 '24 09:06 raphamorim

~@MrPandir could you test with main branch?~

Actually nevermind, I figured out the fix but I want to do it properly 👌

raphamorim avatar Aug 18 '24 20:08 raphamorim

Yes, I confirm this has been fixed. 👍

MrPandir avatar Aug 19 '24 17:08 MrPandir

In the latest main? https://github.com/raphamorim/rio/commit/ecc427072d565a0be095fa63745cd800f0dde2f1

raphamorim avatar Aug 19 '24 18:08 raphamorim

In the latest main? ecc4270

No, it wasn't fixed. It seems you rolled back the changes.

MrPandir avatar Aug 19 '24 19:08 MrPandir

Yup! will do a proper fix for it but at least figured out the issue haha :D

raphamorim avatar Aug 19 '24 21:08 raphamorim

@MrPandir could you test main again?

raphamorim avatar Aug 21 '24 22:08 raphamorim

@MrPandir could you test main again?

Yes, that has been fixed. 👍

https://github.com/user-attachments/assets/d694c6d6-f5e0-4427-8642-bb9e000a2f6f

MrPandir avatar Aug 22 '24 08:08 MrPandir

That’s great! Thanks for testing

raphamorim avatar Aug 22 '24 09:08 raphamorim