rio icon indicating copy to clipboard operation
rio copied to clipboard

Unremovable bottom padding when using line-height

Open laulauland opened this issue 2 years ago • 6 comments

I've set the line height property to 1.2 and it seems that all terminal rendering now has this bottom padding (see screenshot):

line-height = 1.2
CleanShot 2024-02-05 at 17 24 12@2x

laulauland avatar Feb 05 '24 16:02 laulauland

I have a similar issue. For me, the padding appears above the tab list (with navigation.mode = "BottomTab").

image

Full config
editor = 'vim'
cursor = '▇'
blinking-cursor = false
theme = 'onedark'
padding-x = 10
line-height = 1.2

[window]
mode = "Maximized"

[fonts]
family = "FiraCode Nerd Font Mono"
size = 19

[scroll]
multiplier = 5.0
divider = 1.0

[navigation]
mode = "TopTab"
clickable = true

Artemis21 avatar Feb 07 '24 19:02 Artemis21

Same here. Also the viewport overflows when you set the line height to a value less than 1.

taggon avatar Feb 08 '24 12:02 taggon

Thanks for the issue!

Yea, currently line-height property is quite unstable, I am fixing it in #428 (which will add some text rendering features as well).

raphamorim avatar Feb 08 '24 13:02 raphamorim

Hi @raphamorim -- looks like #428 was merged but seems the padding is still an issue?

ehamiter avatar May 31 '24 17:05 ehamiter

Yes, it is still an issue. Will be looking it for the upcoming versions (probably next one), sorry about delay!

raphamorim avatar Aug 26 '24 17:08 raphamorim

@raphamorim Just started using Rio the other day, feels like a great terminal! The ability to adjust the line height is the only thing I am missing so far.

kristoferlund avatar Sep 29 '24 07:09 kristoferlund