rio icon indicating copy to clipboard operation
rio copied to clipboard

Mouse selection is off by a few characters

Open Stupremee opened this issue 2 years ago • 5 comments

Hey,

I've just started using Rio, and am really happy. Except one thing. Whenever I use my mouse to select something, the selection is always of by one or even more characters.

I'm using the new GitHub Monaspace Font, which I would like to keep, so I hope this can be fixed.

https://github.com/raphamorim/rio/assets/39732259/9d40dfdd-89d1-46ce-962e-f286bf09422a

https://github.com/raphamorim/rio/assets/39732259/b83066f4-d1d7-466e-8c0e-3841c4c234a9

Stupremee avatar Dec 14 '23 08:12 Stupremee

@Stupremee the videos looks corrupted. Do you have any kind of scaling turned on? I reckon you can post your configuration for better clarity here. Cheers!

RaySlash avatar Dec 15 '23 01:12 RaySlash

Hi @RaySlash

That's weird because the videos work for me. I will try to upload new ones here.

https://github.com/raphamorim/rio/assets/39732259/13ba2066-6d37-4323-baae-53b302bd1242

This is my Rio Terminal config: https://paste.rs/1h3fi

Stupremee avatar Dec 15 '23 08:12 Stupremee

@Stupremee videos are still broken or is that how u see. All I see is this: Screenshot_20231216-163928

Black bg with some grain like pixels.

RaySlash avatar Dec 16 '23 06:12 RaySlash

FWIW videos are working for me (chrome+macos) image

Regarding text selection, it is working better than in previous versions but it still needs some work, I believe it is related to the font rendering issues.

ralgozino avatar Jan 08 '24 11:01 ralgozino

Hi,

The problem does not only concerns the selection, but all mouse interactions. It also depends on the size of the font and increases with the distance to the top left corner. As such I think it is a problem of converting screen coordinates into grid coordinates that does not properly consider the size of a character in the current font.

Lattay avatar Feb 13 '24 18:02 Lattay

Hey there! thanks for the issue, this should be gone (fixed by #374). Please let me know anything!

raphamorim avatar Aug 13 '24 08:08 raphamorim