raphaelrobert

Results 37 comments of raphaelrobert

Thanks for tackling it! I think AAD really is the outlier here and I should get working on #1521 instead. I thought about it some more, and the current way...

> Do you want to do your aad changes inside this PR or do you want to do it separately @raphaelrobert? Not sure how to interpret your self-assign :) Self-assign...

This is likely a leftover from before we had the signer trait. We want to keep the signer trait and instead delete the unused functions from the crypto provider.

I think there are enough breaking changes to move to 0.7.

Hi! I suppose that's related to the cli PoC? The library itself doesn't do any networking.

The scope is actually larger, we should have the same API for - self-updates - proposed self-updates - external commits. It should be possible to set - a new credential...

Removing the bug label since this doesn't lead to documented malfunction.

Since the spec implies that there should be a KeyPackage upon group creation, we should pass a KeyPackage as a parameter.

Sounds reasonable to me. Can this be automated by configuring it in a config file somehow? I suppose we would want to check this with the CI as well, so...

Is it just the warning, or does the formatting not work at all when configured through `rustfmt.toml`? I think running a custom command before committing/pushing will lead to a lot...