Raphael Simon comments

Results 128 comments of


                                            Raphael Simon

Question/Feature: CORS does not work for GOA generated grpc servers

I'd be happy to merge a PR that would add this functionality!

[docs] content keeps getting appended if a different output directory is specified

This is a current known limitation, the plugin does not have access to the custom location and changing the interface with Goa would be a breaking change. There might be...

ConvertTo ConvertFrom not generating any code in v3.8.2

Looks like the design is missing a few pieces (e.g. `ValidationResponse` and `SomeService` isn't formatted right (missing closing brace and parenthesis). Are you able to provide a functional design that...

Question/Feature: [CORS] Setting origin at runtime

Hello, you are correct that there is no way to do that at the moment. I'd be curious to understand a bit more about the use case? could you use...

Question/Feature: [CORS] Setting origin at runtime

Yeah, that could work and is probably the easiest way to implement the desired behavior. A cleaner way might be for the plugin to override the generated server struct (https://github.com/goadesign/plugins/blob/6962488b0bf6c21dacd44e4be0f28898f32504e9/cors/examples/calc/gen/http/calc/server/server.go#L23-L28)...

Question/Feature: [CORS] Setting origin at runtime

Awesome!

Question/Feature: [CORS] Setting origin at runtime

I just released v3.10.2 with the feature - thank you!

Streaming: unable to write error status code

That's great - would you be able to put together a PR that made that change? maybe the check can be done inline since `conn` isn't used for anything else:...

Query parameter mapped via MapParams is not present in OpenAPI spec

Thanks for the nice repro, this is fixed in #3381

Enterprise deprecated

Thanks for raising this! A good ol' search and replace should work pretty well here given that Enterprise is used mostly as metadata. Roughly the DSL has to be added...