node-argon2 icon indicating copy to clipboard operation
node-argon2 copied to clipboard

Please consider adding FreeBSD support (pre-built packages)

Open mike-pt opened this issue 4 years ago • 4 comments

Currently there are no prebuild package for FreeBSD, some projects like code-server depend on node-Argon2 so it would be great.

mike-pt avatar Oct 11 '21 18:10 mike-pt

I'm willing to accept a PR, but I have no knowledge over FreeBSD to do it

ranisalt avatar Oct 16 '21 17:10 ranisalt

I tried to follow the README, not super familiar with building with node/npm but I' might be able to help wtith FreeBSD compatibility however I can't get past this:

$ CXX=clang npm install argon2
npm ERR! code ENOSELF
npm ERR! Refusing to install package with name "argon2" under a package
npm ERR! also called "argon2". Did you name your project the same
npm ERR! as the dependency you're installing?
npm ERR!
npm ERR! For more information, see:
npm ERR!     <https://docs.npmjs.com/cli/install#limitations-of-npms-install-algorithm>

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/user/.npm/_logs/2021-10-19T12_20_08_217Z-debug.log

P.S. sorry if you got 2 notifications on this, I initially replied using my work account -.-'

Also I think I get it its probably just "npm install" no need for the name

mike-pt avatar Oct 19 '21 12:10 mike-pt

Oh this is great, this is actually a dep in code.server, I will see if I can build it now using the new package.

Many thanks

mike-pt avatar Dec 30 '21 21:12 mike-pt

There you go! Update to v0.29.1

ranisalt avatar Aug 23 '22 11:08 ranisalt