fleet icon indicating copy to clipboard operation
fleet copied to clipboard

[SURE-7365?] Update status fields to provide what UI needs for "resourceCount"

Open manno opened this issue 2 years ago • 0 comments

Background

The old key BundleStatus.ResourceKey https://fleet.rancher.io/ref-crds#resourcekey works like this:

ResourceKey lists resources, which will likely be deployed. The actual list of resources on a cluster might differ, depending on the helm chart, value templating, etc..

The sum of all resources in bundles is stored in the GitRepo. This seems to multiply the estimate.

We want to use the accurate resource lists and counts. The BundleDeploymentStatus.Resources lists the actual deployed resources from Helm:

Resources lists the metadata of resources that were deployed according to the helm release history.

Open

  • [ ] do we still need helm template in fleet controller?
  • [ ] what views in the UI use the resource list? what makes sense?
    • 1 gitrepo -> n bundles -> n clusters
    • resources per cluster
    • resources per gitrepo
  • [ ] can the UI use bundledeployment.resources directly?
  • [ ] is there a view for resources/bundles of a gitrepo per cluster?
  • [ ] are the conditions like "Failed", in the proper case and documented. (Is "Active" a failure state?) - Probably a separate issue.
  • [ ] should work bundlenamespacemapping

TODO

  • [ ] populate gitrepo.resources from bundledeployment.resources?
  • [ ] populate bundle.resources from bundledeployment.resources?
  • [ ] status derived from resources in bundle reconciler
  • [ ] status derived from resources in gitrepo reconciler
  • [ ] resource count calculation in cluster reconciler
  • [ ] resource count calculation in clustergroup reconciler?
  • [ ] deprecate resourceKey and related outdated status fields

Also see:

  • https://github.com/rancher/fleet/issues/1101

manno avatar Jan 31 '24 15:01 manno