types icon indicating copy to clipboard operation
types copied to clipboard

[WIP] fix(propEq): improve propEq typings

Open Nemo108 opened this issue 2 years ago • 3 comments

  • remove unnecessary constraint from propEq value: the function should receive any type values of object, no matter what parameter it received;
  • add additional types to use with placeholder

Nemo108 avatar Oct 15 '23 08:10 Nemo108

@Nemo108 I finally got around to re-checking and merging https://github.com/ramda/types/pull/71. Rebase this one for me and I'll recheck it

Harris-Miller avatar Jan 20 '24 22:01 Harris-Miller

@Harris-Miller done

Nemo108 avatar Jan 21 '24 09:01 Nemo108

@Nemo108 I'm having to revert the other propEq we collaborated on together: https://github.com/ramda/types/pull/74/ (see: https://github.com/ramda/types/pull/99)

This MR is actually of of develop before that merge, so after the revert happens there should be no more merge conflict.

The additions made to https://github.com/ramda/types/pull/74/ solved a different problem about propEq. I pretty sure the changes in this MR are find to merge without those changes. I'm also pretty sure that the specific change of https://github.com/ramda/types/pull/74/ that broke it (argument possibly being never) not present in these changes, so we shouldn't have that problem again

Harris-Miller avatar Feb 22 '24 05:02 Harris-Miller