various tiny changes

[omentic]

[omentic]

oh also do you want quote toots? i have yet to figure out how mutes work exactly but can pull together a patch for quote toots from existing impls pretty quickly now

[ionathanch]

We'll hold off on quote toots for this PR

[omentic]

okay, i'll get around to this wednesday (day after finals)

[omentic]

there are other changes i want to pull in, here or as separate PRs:

• [ ] mathstodon has a latex patch directly integrated into the compose modal: https://github.com/christianp/mastodon/tree/mathstodon-4.2
• [ ] treehouse.systems has quote toots (no strong feelings on this, but displaying quote toots properly at least seems nice): https://gitea.treehouse.systems/treehouse/mastodon
• [x] catstodon has a fix for like propagation: https://git.kescher.at/CatCatNya/catstodon/commit/16be9e975b495c43035cda4e82ead2cb5374f700
• [ ] chuckya has emoji reactions: https://github.com/glitch-soc/mastodon/pull/2462
• neuromatch.social is working on a patch to pull in replies from other instances: https://neuromatch.social/@jonny/112307981094627966
• [x] the ui revamp broke oatstodon.css also... i really need to fix it, that'll probably be tacked onto here
• [x] also fixes to cyberspace

[omentic]

notes to self: other things i would like to do that are more involved, so depend on how much time i'm able to put into them / actually getting the build system to function:

• username renaming and post migration. these kind of go hand in hand: https://types.pl/@jj/111973561247740433. as i understand it it requires deep enough knowledge of mastodon internals that i do not think this is super doable well unless a patch already exists. (it would be doable poorly. by grepping for all internal usages of usernames in url accesses and replacing those with accesses by actor ids. but)
• mutes collapsing instead of removing replies by default. i just haven't had the time to see how doable it is yet (edit: adapt https://github.com/mastodon/mastodon/pull/26904?)
• check out other themes. i just need a working build environment (https://codeberg.org/Freeplay/Mastodon-Modern?)
• play around with implementing a bubble timeline a la akkoma? conceptually this is pretty simple, you just hijack and filter the firehouse. the tricky part will be adding support in settings and what not
• see how doable reverting the icons and particularly bringing back the animations are. (they still exist!! in picture modals.) also remove the threaded mode icon

[omentic]

this is about everything simple that i can do without a build environment. i'd like to make the cybre.space flavour not a separate skin from the "default" skin, but i can't do that without testing it out as i'm not quite sure how it works

[omentic]

grr i keep finding tiny little oatstodon css issues. that hopefully is the last of them

[omentic]

okay, this is done, for real. everything else will be separate

[ionathanch]

cybrespace theme broken don't know why. Going to /settings/flavours/cybrespace gives the "We're sorry, but something went wrong on our end." page and journalctl -u mastodon-web only seems to say this:

Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88]      5:   = render 'shared/error_messages', object: current_user
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88]      6:
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88]      7:   - Themes.instance.flavour(@selected)['screenshot'].each do |screenshot|
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88]      8:     %img.flavour-screen{ src: frontend_asset_url(screenshot), alt: '' }
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88]      9:
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88]     10:   .flavour-description
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88]     11:     = t "flavours.#{@selected}.description", default: ''
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88]
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88] app/helpers/routing_helper.rb:28:in `frontend_asset_path'
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88] app/helpers/routing_helper.rb:32:in `frontend_asset_url'
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88] app/views/settings/flavours/show.html.haml:8
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88] app/views/settings/flavours/show.html.haml:7:in `each'
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88] app/views/settings/flavours/show.html.haml:7
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88] app/views/settings/flavours/show.html.haml:4
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88] app/controllers/concerns/localized.rb:11:in `set_locale'
Jun 23 18:52:04 types bundle[3621]: [c534eece-a9ec-45d5-9808-cdc619ca9d88] lib/mastodon/rack_middleware.rb:9:in `call'

but cybrespace-preview.png is correctly located

[ionathanch]

RAILS_ENV=production bundle exec rails assets:precompile is failing to put the screenshot into public/packs/media/flavours/cybrespace/images for unknown reasons so I'm going to just remove the screenshot link for now and come back to it later