jbuilder icon indicating copy to clipboard operation
jbuilder copied to clipboard

Caching improvements

Open dirk opened this issue 10 years ago • 5 comments

Implementation of the serialization-deserialization-overhead-eliminating strategy outlined in #289. Please see that issue for an outline and general details of the strategy.

dirk avatar Oct 06 '15 03:10 dirk

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rwz (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rails-bot avatar Oct 06 '15 03:10 rails-bot

Please see this comment on the proposal pull request for performance results.

dirk avatar Oct 06 '15 21:10 dirk

@dirk would love to try this out, do you have a fork you are maintaining for your own projects?

rromanchuk avatar May 26 '17 19:05 rromanchuk

have you seen before?

ActionView::Template::Error (can't add a new key into hash during iteration): occurs when there is another nested cache!

rromanchuk avatar May 31 '17 02:05 rromanchuk

@rromanchuk I think the error is raised when a template call same template itself.

# model/_template.jbuilder
if model[:child].present?
  json.child model[:child], partial: 'model/template', as: :model
else
  json.child []
end

mactkg avatar Jul 27 '17 08:07 mactkg