raiden-token icon indicating copy to clipboard operation
raiden-token copied to clipboard

external visibility is sufficient instead of public visibility

Open ethers opened this issue 8 years ago • 0 comments

In auction.sol (and potentially other files), is there a reason why functions like setup(), addToWhitelist() etc are public instead of external? They are not being called internally, so external visibility is sufficient.

https://github.com/ConsenSys/smart-contract-best-practices#explicitly-mark-visibility-in-functions-and-state-variables

ethers avatar Oct 17 '17 20:10 ethers