light-client icon indicating copy to clipboard operation
light-client copied to clipboard

[Feature Request] Simplify UDC minting, allowance and deposit

Open eorituz opened this issue 5 years ago • 4 comments

Description

Using the latest CLI version I had to manually mint, allow and deposit the raiden service token with the UserDeposit Contract (UDC). It would be great to either have an endpoint to do that for me or to have that done automatically during the startup period.

Acceptance criteria

  • Have the minting, allowance and deposit of the raiden service token with the UDC done "automatically"

Info

The addresses of the SC can be found here:

(demo_train) pi@NanoPi-Duo2:~/demo-train$ http https://pfs.demo001.env.raiden.network/api/v1/info
HTTP/1.1 200 OK
Access-Control-Allow-Headers: Origin, Content-Type, Accept
Access-Control-Allow-Methods: GET,POST,OPTIONS
Access-Control-Allow-Origin: *
Content-Length: 593
Content-Type: application/json
Date: Wed, 01 Jul 2020 13:27:45 GMT

{
    "UTC": "2020-07-01T13:27:45.834225",
    "contracts_version": "0.37.0",
    "matrix_server": "https://transport.demo001.env.raiden.network",
    "message": "Welcome!",
    "network_info": {
        "chain_id": 5,
        "confirmed_block": {
            "number": 2970341
        },
        "service_token_address": "0x5Fc523e13fBAc2140F056AD7A96De2cC0C4Cc63A",
        "token_network_registry_address": "0x5a5CF4A63022F61F1506D1A2398490c2e8dfbb98",
        "user_deposit_address": "0x0794F09913AA8C77C8c5bdd1Ec4Bb51759Ee0cC5"
    },
    "operator": "Brainbot_technologies",
    "payment_address": "0x956b18Fb47F9626DDbA869feb3e91bF94224E767",
    "price_info": 100,
    "version": "0.10.0"
}

The old CLI was able to do that automatically for me which was an insane improvement to UX

eorituz avatar Jul 01 '20 13:07 eorituz

Just for the planning by @christianbrb : since we approach mainnet as first priority, how urgent/important is this feature for your demo project?

weilbith avatar Jul 02 '20 09:07 weilbith

This is a question for @eorituz ;) right?

For me it’s ok, if we pull it ahead in the Product Backlog

christianbrb avatar Jul 02 '20 11:07 christianbrb

Not important to me but for externals trying to play with the CLI it will be the most important feature. I assume they have no clue that they have to mint, approve and deposit those tokens.

I'd say: Work on the main net release and set this issue as prio for afterwards.

eorituz avatar Jul 02 '20 12:07 eorituz

@eorituz is this still relevant? We do have the endpoints to do all of the above, not in one endpoint though.

taleldayekh avatar Jun 21 '21 13:06 taleldayekh