primitives [Dialog] Make portaled scroll containers scrollable

Description

As the shards of RemoveScroll are not portal friendly, just moving RemoveScroll to Content solves the problem but this approach has shown to have a problem with OuterScrollable setup, i.e. the scroll event does not bubble up to Overlay if it happens in Content. So to cover this case I opted to render RemoveScroll in both Overlay and Content and enable/disable depending on whether Content is inside Overlay or not.

Fixes #1159

Jul 04 '23 16:07 joaom00

When will it be merged?

Jul 17 '23 12:07 dogukanoksuz

excited for this 😄

Jul 21 '23 14:07 sgrund14

@benoitgrelard @andy-hook please give a look, we're waiting exited, thanks!

Aug 02 '23 11:08 kulgavy

Hey everyone, any news on this? This is also blocking me and my team 👀 Thanks!

Oct 11 '23 04:10 Rieranthony

Up

Oct 20 '23 19:10 lramos33

Up

Oct 23 '23 03:10 lukasburns

Also waiting for this. Is there any workaround for scrolling inside portaled Popover?

Oct 24 '23 14:10 riccardolardi

Also waiting for this. Is there any workaround for scrolling inside portaled Popover?

Try wrapper the dialog content with the overlay

<Dialog.Overlay>
  <Dialog.Content>
    ...
  </Dialog.Content>
</Dialog.Overlay>

Oct 24 '23 15:10 joaom00

Also waiting for this. Is there any workaround for scrolling inside portaled Popover?

Try wrapper the dialog content with the overlay
<Dialog.Overlay>
  <Dialog.Content>
    ...
  </Dialog.Content>
</Dialog.Overlay>

Thank you but I'm using the Popover primitive, which does not offer any Overlay. Is there any way to get around it with Popover too?

Oct 24 '23 15:10 riccardolardi

Also waiting for this. Is there any workaround for scrolling inside portaled Popover?

Try wrapper the dialog content with the overlay
<Dialog.Overlay>
  <Dialog.Content>
    ...
  </Dialog.Content>
</Dialog.Overlay>
Thank you but I'm using the Popover primitive, which does not offer any Overlay. Is there any way to get around it with Popover too?

Maybe your issue is different. This PR is for a specific issue when used within Dialog. Would you mind opening a ticket and sharing a reproduction example there? Thanks

Oct 24 '23 16:10 joaom00

up 👀

Oct 30 '23 22:10 tcolinpa

up 👀

Mar 06 '24 09:03 jgoncalv

up

Mar 07 '24 05:03 dogukanoksuz

@joaom00 Thank you for you solution, it fixed my exact problem!

Had my overlay like this:

<Ovelay />
<Content>...</Content>

and changing to this made everything still behave the same, but fixes the scroll issue:

<Overlay>
  <Content>...</Content>
<Overlay/>

May 11 '24 22:05 klingat