docs icon indicating copy to clipboard operation
docs copied to clipboard
verified publisher icon radius-project

Need to add commit sign-off to the PR created by the upmerge workflow

Open ytimocin opened this issue 1 year ago • 3 comments

Need to add commit sign-off to the PR created by the upmerge workflow

AB#13198

ytimocin avatar Sep 13 '24 17:09 ytimocin

@ytimocin pls add more context. Clarify impact to the release process.

lakshmimsft avatar Sep 16 '24 19:09 lakshmimsft

The PR that is created by this workflow has a commit that is not signed off. I think (but I am not sure) the bot that creates this PR needs a DCO permission. See an example here.

ytimocin avatar Sep 16 '24 19:09 ytimocin

There is no impact to the release process. You just need to manually set the DCO to pass.

ytimocin avatar Sep 19 '24 19:09 ytimocin