el-patch icon indicating copy to clipboard operation
el-patch copied to clipboard

Patches get silently overridden on package update / native compilation

Open sebmiq opened this issue 3 years ago • 2 comments

Hi,

A few of my patches keep getting silently overridden, I assume because the original definition is reevaluated by native compilation.

Using advice as suggested in #60 would be one way to fix this, perhaps.

sebmiq avatar Jun 22 '22 20:06 sebmiq

Yes, that's a known issue. There are reasons to stick to the existing way of doing things, as mentioned in https://github.com/radian-software/el-patch/issues/60#issuecomment-1126230778, but I suppose it would not be a bad idea to at least make it customizable whether the user would prefer for functions to be patched using advice rather than being overwritten.

raxod502 avatar Sep 29 '22 20:09 raxod502

See #63 for a possible implementation and further discussion on the pitfalls of advising.

haji-ali avatar Jan 25 '23 10:01 haji-ali