react-native-viewpager icon indicating copy to clipboard operation
react-native-viewpager copied to clipboard

pass props through pageIndicator

Open jeongmincha opened this issue 8 years ago • 0 comments

After I looked at your codes deeply, it don't provide a feature to pass props to customized page indicator. When I want to pass props to customized page, I can write as:

renderPage={(data:Object, pageID: number | string,)=>{
  return (...)
}}

However, renderPageIndicator method don't any parameter.

renderPageIndicator={()=>{
  return (...)
}}

In your codes, renderPage method will take arguments by using this.props.renderPage.bind(...) but renderPageIndicator don't use bind() anywhere. That's why we can't pass props through renderPageIndicator method.

I think it should be implemented.

jeongmincha avatar Apr 02 '17 15:04 jeongmincha