styler icon indicating copy to clipboard operation
styler copied to clipboard

Quarto: Test that unexecuted blocks aren't styled

Open IndrajeetPatil opened this issue 3 years ago • 12 comments

  • https://quarto.org/docs/output-formats/html-code.html#code-overflow

  • https://quarto.org/docs/computations/execution-options.html#unexecuted-blocks

IndrajeetPatil avatar Aug 07 '22 05:08 IndrajeetPatil

Codecov Report

Merging #973 (27e45c0) into main (340e07b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #973   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          47       47           
  Lines        2697     2697           
=======================================
  Hits         2434     2434           
  Misses        263      263           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 07 '22 05:08 codecov-commenter

This is how benchmark results would change (along with a 95% confidence interval in relative change) if bee7d7cc996034cf1ce5778a260a566892181479 is merged into main:

  •   :ballot_box_with_check:cache_applying: 28.3ms -> 28.4ms [-2.26%, +3.26%]
  •   :ballot_box_with_check:cache_recording: 1.16s -> 1.16s [-1.79%, +1.96%]
  •   :ballot_box_with_check:without_cache: 3.1s -> 3.06s [-2.89%, +0.86%]

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] avatar Aug 07 '22 06:08 github-actions[bot]

Thanks. I am not sure how code overflow plays a role here. Can you explain? Also I am not sure we never want to style code blocks not intended for running. Are you aware of the code option tidy = FALSE for Rmarkdown? styler won't style these chunks, but only if probided in the header like {r, tidy = FALSE}, not as a comment like #| tidy = FALSE or #| tidy: False. The ladder might be another issue and a reason why we should use proper params parsing from knitr, as discussed in https://github.com/yihui/knitr/issues/2112.

lorenzwalthert avatar Aug 07 '22 15:08 lorenzwalthert

@IndrajeetPatil any thoughts on these remarks?

lorenzwalthert avatar Aug 13 '22 11:08 lorenzwalthert

I will create a separate issue for this, and we should discuss this a bit more because it's trickier than I initially thought.

IndrajeetPatil avatar Aug 15 '22 06:08 IndrajeetPatil

This is how benchmark results would change (along with a 95% confidence interval in relative change) if ac1b88bfb7760dfd1e6817fb1f07d68289094020 is merged into main:

  •   :ballot_box_with_check:cache_applying: 24.4ms -> 24.4ms [-0.64%, +0.76%]
  •   :ballot_box_with_check:cache_recording: 908ms -> 910ms [-0.23%, +0.72%]
  •   :ballot_box_with_check:without_cache: 2.4s -> 2.39s [-0.85%, +0.54%]

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] avatar Aug 15 '22 07:08 github-actions[bot]

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 491f71ecef796bd8106f273e40573ad2c3b95cde is merged into main:

  •   :ballot_box_with_check:cache_applying: 36.9ms -> 35.7ms [-8.25%, +2.08%]
  •   :ballot_box_with_check:cache_recording: 1.8s -> 1.82s [-1.92%, +3.73%]
  •   :ballot_box_with_check:without_cache: 4.84s -> 4.82s [-2.85%, +1.77%]

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] avatar Aug 22 '22 14:08 github-actions[bot]

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e5d885d9610a4061eeccd940e0a8bb45596b74ed is merged into main:

  •   :ballot_box_with_check:cache_applying: 24.2ms -> 24.1ms [-1.14%, +0.66%]
  •   :ballot_box_with_check:cache_recording: 1.1s -> 1.1s [-0.98%, +0.71%]
  •   :ballot_box_with_check:without_cache: 2.92s -> 2.92s [-0.43%, +0.84%]

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] avatar Aug 22 '22 19:08 github-actions[bot]

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 46fabd286a4bec6c655b28c0bffbc1a5bad6f004 is merged into main:

  •   :ballot_box_with_check:cache_applying: 34.2ms -> 34.2ms [-4.58%, +4.24%]
  •   :ballot_box_with_check:cache_recording: 1.78s -> 1.75s [-3.28%, +0.51%]
  •   :ballot_box_with_check:without_cache: 4.69s -> 4.67s [-1.21%, +0.51%]

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] avatar Aug 24 '22 09:08 github-actions[bot]

This is how benchmark results would change (along with a 95% confidence interval in relative change) if c0edeadedf8e4e23f20f81c5577217921942b0c4 is merged into main:

  •   :ballot_box_with_check:cache_applying: 27.6ms -> 27.5ms [-1.51%, +0.95%]
  •   :ballot_box_with_check:cache_recording: 1.24s -> 1.23s [-3.51%, +1.18%]
  •   :ballot_box_with_check:without_cache: 3.42s -> 3.38s [-3.14%, +0.87%]

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] avatar Aug 26 '22 12:08 github-actions[bot]

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 93386f263d923985d37baa600f755f44794a3c5d is merged into main:

  •   :ballot_box_with_check:cache_applying: 27.7ms -> 28ms [-0.24%, +1.82%]
  •   :ballot_box_with_check:cache_recording: 1.31s -> 1.31s [-0.64%, +0.4%]
  •   :ballot_box_with_check:without_cache: 3.44s -> 3.45s [-0.23%, +0.69%]

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] avatar Sep 11 '22 10:09 github-actions[bot]

This is how benchmark results would change (along with a 95% confidence interval in relative change) if ec4828f9f907397641bf4e1f1afb77b053e7f893 is merged into main:

  •   :ballot_box_with_check:cache_applying: 23.9ms -> 23.8ms [-0.66%, +0.41%]
  •   :ballot_box_with_check:cache_recording: 1.09s -> 1.09s [-0.61%, +0.43%]
  •   :ballot_box_with_check:without_cache: 2.89s -> 2.9s [-0.49%, +0.56%]

Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] avatar Sep 13 '22 19:09 github-actions[bot]