sqlhooks icon indicating copy to clipboard operation
sqlhooks copied to clipboard
verified publisher icon qustavo

Add lint ci

Open ehrktia opened this issue 4 years ago • 7 comments

add lint to ci

ehrktia avatar Dec 28 '21 12:12 ehrktia

hey, thanks for this but it looks like in your last commit you've removed the linting instructions (?)

qustavo avatar Dec 28 '21 20:12 qustavo

Hi @qustavo ,yes I tried to have both lint and test in same action as multiple steps then moved it to separate using existing lint.yml. This is because of the best practise suggested by the golang-ci lint official action.

ehrktia avatar Dec 28 '21 21:12 ehrktia

Hi @qustavo ,yes I tried to have both lint and test in same action as multiple steps then moved it to separate using existing lint.yml. This is because of the best practise suggested by the golang-ci lint official action.

Are you sure that the lint.yml has been committed and pushed, I can't see it on your PR.

qustavo avatar Dec 28 '21 21:12 qustavo

Hi @qustavo ,yes I tried to have both lint and test in same action as multiple steps then moved it to separate using existing lint.yml. This is because of the best practise suggested by the golang-ci lint official action.

Are you sure that the lint.yml has been committed and pushed, I can't see it on your PR.

https://github.com/qustavo/sqlhooks/pull/49/commits/029a9f2ad5b1e5d9f2903de166530a1fe596371a commit has lint.yml with one change in to include pull and push.

ehrktia avatar Dec 28 '21 21:12 ehrktia

For some reason I can't see that commit on this PR Screenshot_2021-12-29_09-41-48

I also noticed that sqlhooks already has a lint.yml (added here: https://github.com/qustavo/sqlhooks/commit/6d849c52e98a5bb2c77700e82c40c90492201fc1), so maybe we should close the issue and this pr?

qustavo avatar Dec 29 '21 08:12 qustavo

For some reason I can't see that commit on this PR Screenshot_2021-12-29_09-41-48

I also noticed that sqlhooks already has a lint.yml (added here: 6d849c5), so maybe we should close the issue and this pr?

sorry for delay in reply, am able to see the commit in the PR .https://github.com/qustavo/sqlhooks/pull/49/commits/029a9f2ad5b1e5d9f2903de166530a1fe596371a

ehrktia avatar Dec 30 '21 20:12 ehrktia

anyway, there is already linting support on the current pipeline, what's missing that you'd like to change?

qustavo avatar Dec 31 '21 22:12 qustavo