node-logger icon indicating copy to clipboard operation
node-logger copied to clipboard

sys-to-util

Open bradcgarner opened this issue 7 years ago • 4 comments

line 32 of logger.js required 'sys', which is deprecated. Updated to require 'util'.

bradcgarner avatar Mar 29 '18 18:03 bradcgarner

@quirkey any updates on this? Would love to keep logger in my project.

MatthewSH avatar May 13 '18 06:05 MatthewSH

@MatthewSH I didn't hear back, but logger is working like a charm for me. I forked it and just dropped the code in a file to my codebase with the edit; I'm no longer using it as an NPM dependency. I made one other edit to logger (in my code) after this pull request: changed a system.out.println() to console.log() for the same reason.

bradcgarner avatar May 14 '18 03:05 bradcgarner

I actually ended up doing the same right after I saw the lack of activity. Shame. Wish he could mark someone else as a maintainer so people could update it.

On May 13, 2018, at 11:31 PM, Brad Garner [email protected] wrote:

@MatthewSH I didn't hear back, but logger is working like a charm for me. I forked it and just dropped the code in a file to my codebase with the edit; I'm no longer using it as an NPM dependency. I made one other edit to logger (in my code) after this pull request: changed a system.out.println() to console.log() for the same reason.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

MatthewSH avatar May 14 '18 09:05 MatthewSH

I was about to make the same merge request but i'm happy to see someone else did. Hope the author will accept you modifications soon ! But notice the fact that their is a pull request from a branch for this issue since 2012...

ghost avatar Jun 08 '18 13:06 ghost