sm64tools icon indicating copy to clipboard operation
sm64tools copied to clipboard

Fixing several buffer overflow in parse_arguments in n64split

Open Sn0wfreezeDev opened this issue 6 years ago • 0 comments

Hi,

for a university project we had look for buffer overflows in open source projects. We have tested your software and discovered several buffer overflows in the n64split tool.

We have fixed those in this commit using strncpy instead of strcpy.

To reproduce the buffer overflow compile n64split with the gcc flag -fno-stack-protector and run it with the following input: ./n64split $(python -c "print ''.join(c * 4096 for c in 'ABC') + 'D' * 72")

This will create a segmentation fault, because it will overwrite among others the return address of the main function.

Sn0wfreezeDev avatar Jan 31 '19 14:01 Sn0wfreezeDev