efficientnet icon indicating copy to clipboard operation
efficientnet copied to clipboard

Speed up image cropping and resizing

Open krikru opened this issue 6 years ago • 5 comments

krikru avatar Aug 09 '19 15:08 krikru

Hi @krikru Thanks for proposed changes, but I am not sure that OpenCV dependencies is a good choice, you could wrap it in try except block, if cv2 is exists use it, else skimage.

qubvel avatar Aug 09 '19 17:08 qubvel

I have updated my pull request. How does this code look?

krikru avatar Aug 14 '19 15:08 krikru

@qubvel I have three pending pull requests, including this one. Will they be merged?

krikru avatar Oct 23 '19 19:10 krikru

Opencv returns BGR image, while scikit-image returns RGB image, I wonder if you tested the result?

Clara85 avatar Feb 06 '20 13:02 Clara85

@Clara85 Tested in what regard? When resizing, OpenCV only returns a BGR image if it is fed a BGR image as input; if you feed it an RGB image it will also return an RGB image (it has no way of telling whether the image is a BGR or an RGB image, and therefore won't rearrange the channel order).

krikru avatar Feb 24 '20 15:02 krikru