quasar-testing icon indicating copy to clipboard operation
quasar-testing copied to clipboard

Support for eslint-plugin-jest 29.0.0

Open CamilleDrapier opened this issue 5 months ago • 3 comments

Since eslint-plugin-jest 29.0.0 was released a short while ago, it would be great if @quasar/quasar-app-extension-testing-unit-jest would allow using it.

I have run a few test with eslint-plugin-jest 29.0.0, and it seems to be generally working, but maybe there is more than just adding the 29.0.0 version to the allowed peer dependencies:

-    "eslint-plugin-jest": "^27.1.3 || ^28.0.0",
+    "eslint-plugin-jest": "^27.1.3 || ^28.0.0 || ^29.0.0",

CamilleDrapier avatar Sep 09 '25 23:09 CamilleDrapier

This should be an easy release, could you draft a PR and test it on the test projects? You'll need to update eslint-plugin-jest in devDependencies to properly test it

Check out jest:sync:invoke and similar commands in the relevant test projects See https://github.com/quasarframework/quasar-testing/blob/dev/packages/unit-jest/README.md#testing-the-ae

IlCallo avatar Sep 16 '25 07:09 IlCallo

Thanks @IlCallo I made the change, tested them locally (to some extent~) and created this PR 🙇

CamilleDrapier avatar Sep 16 '25 10:09 CamilleDrapier

This should be an easy release

Aaaaand I was wrong 😅

v29 drops support for Node 18, thus we need to release a new major version for this I cannot commit to an estimate for this, as it requires to do a round of deps upgrade, many of which released new major versions

IlCallo avatar Oct 02 '25 13:10 IlCallo