quasar-starter-kit icon indicating copy to clipboard operation
quasar-starter-kit copied to clipboard

eslint: Add vue setup compiler macros

Open tennox opened this issue 4 years ago • 5 comments

See:

  • https://dev.to/imomaliev/til-2021-10-04-fix-script-setup-defineprops-is-not-defined-38ic
  • https://eslint.vuejs.org/user-guide/#faq

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [x] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] It's submitted to the dev branch and not the master branch
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] It's been tested with all Quasar themes
  • [ ] It's been tested on a Cordova (iOS, Android) app
  • [ ] It's been tested on a Electron app
  • [ ] Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

tennox avatar Feb 18 '22 03:02 tennox

Hey there! Thanks for your contribution, do you know if there's any other thing which must be configured when using script setup at ESLint level? I noticed there are some other Vue rules which should be adapted

Do you have the time to add a prompt question asking "do you plan to use

IlCallo avatar Feb 18 '22 10:02 IlCallo

Hi, so I've figured, the setting in this PR only works when upgrading eslint-plugin-vue to v8

Is this feasible for the starter kit? (I know it works - I'm using it)

If yes I can also do the work of checking with a fresh start kit what is needed for other script setup things.

tennox avatar Feb 18 '22 13:02 tennox

I think half of the ecosystem is waiting for eslint-plugin-node to support ESLint 8 See https://github.com/quasarframework/quasar-starter-kit/issues/167

We could just do the upgrade for some ESLint presets, but it would be hard to maintain, that's why we are waiting to do the switch

IlCallo avatar Feb 18 '22 16:02 IlCallo

I see... works fine for me, but I see there are still issues so this PR will have to wait :tipping_hand_man:

Added a shy bump to the eslint-plugin-node issue :yum:

Thx :)

tennox avatar Feb 19 '22 11:02 tennox

Thanks to you for caring and proposing a fix :)

IlCallo avatar Feb 21 '22 09:02 IlCallo