quarto-web icon indicating copy to clipboard operation
quarto-web copied to clipboard
verified publisher icon quarto-dev

docs(html-basics.qmd): make description consistent with `link-external-filter` example code

Open mcanouil opened this issue 1 year ago • 4 comments

The pull request fixes an inconsistency in the example description, making it consistent with the example code.

Fixes quarto-dev/quarto-cli#10780

mcanouil avatar Sep 15 '24 11:09 mcanouil

also note that this example is repeated at https://github.com/quarto-dev/quarto-web/blob/1d47eb81f05ec4b6c48864971a392ef677418eaa/docs/reference/formats/html.json#L444-L445 which also has to be addressed I think

soxofaan avatar Sep 16 '24 07:09 soxofaan

which also has to be addressed I think

For everyone's sake, quarto-web/docs/reference/formats/html.json is autogenerated by tools/reference.ts, which is updated by quarto run tools/reference.ts, as described on our README.

So the workflow here is we first fix the schema files (that's https://github.com/quarto-dev/quarto-cli/pull/10806/), then we run the command above, and do a separate PR here with the results here.

cscheid avatar Sep 16 '24 17:09 cscheid

Indeed for the reference pages. Also why this PR only changes the hardcoded example.

mcanouil avatar Sep 16 '24 17:09 mcanouil

FWIW, the PR I mentioned for the reference pages:

  • https://github.com/quarto-dev/quarto-cli/pull/10806

mcanouil avatar Mar 08 '25 16:03 mcanouil