Usage of make-process in quarto-preview

Open fast-90 opened this issue 2 years ago • 1 comments

Is there any reason to use make-process over start-process-shell-command in the quarto-preview defun? For some reason I am unable to get quarto-preview to work for me as it does not recognise my Jupyter Kernel, however when I open shell and run quarto preview manually it works as expected. I suspect this is because make-process is not reading some of my environment variables related to virtualenv correctly (the problem may be similar to https://github.com/quarto-dev/quarto-emacs/issues/16).

I am able to get it work with start-process-shell-command in my own config, but I wonder if it is something worth considering to implement in the package? Happy to submit a PR, but I just wanted to check this point before I attempt it as I'm not sure on the differences between the two process related commands.

Jun 15 '23 15:06 fast-90

I'm not sure what the end result will look like in your PR, so I can't promise we'll merge. But I definitely will take a serious look at it.

Jun 20 '23 03:06 cscheid