Cirq icon indicating copy to clipboard operation
Cirq copied to clipboard

Add JSON serialisations

Open WingCode opened this issue 8 months ago • 6 comments

closes #3846

WingCode avatar May 30 '25 17:05 WingCode

@WingCode - thank you for working on this. The failing CI checks should give some pointers on what is amiss. Feel free to ask here if you need clarification.

pavoljuhas avatar Jun 05 '25 01:06 pavoljuhas

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.68%. Comparing base (c434f94) to head (ca36452). Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7396    +/-   ##
========================================
  Coverage   98.68%   98.68%            
========================================
  Files        1091     1093     +2     
  Lines       96948    97109   +161     
========================================
+ Hits        95674    95835   +161     
  Misses       1274     1274            

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 07 '25 03:06 codecov[bot]

@pavoljuhas I have fixed the CI checks.

WingCode avatar Jun 07 '25 20:06 WingCode

FYI that @pavoljuhas is out on jury duty (a mandatory civic obligation in the USA) starting today and possibly more days (depending on unpredictable factors). If he had commented on the PR or this issue before and hasn't responded, that's why.

mhucka avatar Jun 11 '25 16:06 mhucka

Please consider setting up a local python environment for development per https://github.com/quantumlib/Cirq/blob/main/docs/dev/development.md#setting-up-an-environment and testing the code on your side first. A full test suite takes a while to run, but you can get fast results using either check/pytest-changed-files or, since you work on serialization, by running

check/pytest -n0 cirq-core/cirq/protocols/json_serialization_test.py

You can also consult the CI logs to find what tests are failing and specifically running those.

pavoljuhas avatar Jun 16 '25 18:06 pavoljuhas

Please consider setting up a local python environment for development per https://github.com/quantumlib/Cirq/blob/main/docs/dev/development.md#setting-up-an-environment and testing the code on your side first. A full test suite takes a while to run, but you can get fast results using either check/pytest-changed-files or, since you work on serialization, by running

check/pytest -n0 cirq-core/cirq/protocols/json_serialization_test.py

You can also consult the CI logs to find what tests are failing and specifically running those.

Thank you for the helpful tip, and apologies for the oversight. I just realized that I was mistakenly pushing fixes to the wrong branch, which ended up triggering the CI unnecessarily. I’ll make sure to be more careful going forward.

WingCode avatar Jun 16 '25 18:06 WingCode