quantopian
fix: #315 - filters dont work and poorly displayed
This fixes a severe bug in the filters, caused by a new version of jQuery (qgrid updated it's jQuery version when moved to Jupyter 2). The <i> tags must have a closing tag </i>, otherwise the dropdown element is rendered inside the <i> tag and causes severe bugs (the filter is floating with no background and also the text boxes, sliders and booleans are not clickable. This means the filter is useless).
Before my fix:
After my fix:
(and also all filters work great now)
Maintainer - can you please release a version after merging this? Thanks.
I would really like to see this fixed because it limits the filtering to be nearly unusable. Is there some way I can help? Btw: tests fail because of https://github.com/quantopian/qgrid/issues/300
I've also come across this issue today, are there any blockers to merging this?
With this PR, all the filters except numerical look fine for me (shown below). Anybody have an idea?
Expected filter should be something like this:
Adding this commit(https://github.com/richardlin047/qgrid/commit/19e76a1227195c5a300c826ca38d5e52369ca780) fixes the display issues with the numerical filter. The div was missing a closing tag.
Both my commit and ofirbit's commit are combined on this branch as a solution: https://github.com/quantopian/qgrid/compare/master...richardlin047:filter_fix
Hi @ofirbit ,
Just wondering if there is any workaround until changes are updated in newer version. I tried to edit same fields as in #315, but still didn't manage to get it going.
I recently moved to jupyter lab and it is kind of annoying not to be able to use filters of qgrid properly as in jupyter notebook.
Thanks.
@EmilGuliyev you can try forking my branch https://github.com/richardlin047/qgrid/commits/filter_fix which includes some fixes on top of the ones by @ofirbit . If you just want to see the changes that were made (only a few lines), check them here: https://github.com/quantopian/qgrid/compare/master...richardlin047:filter_fix
As a head's up, Quantopian is no longer operating, so there will be no more updates to Qgrid
@richardlin047 , Thank you very much for your comments. I also changed those lines in src folder and seems to be working now. That is unfortunate that this project is not maintained by Quantopian anymore. I will check out your fork and it looks like you are actively maintaining it.