qiling icon indicating copy to clipboard operation
qiling copied to clipboard

Example fuzzer for RT-N12 B1 httpd

Open libumem opened this issue 1 year ago • 4 comments

Checklist

Which kind of PR do you create?

  • [x] This PR only contains minor fixes.
  • [ ] This PR contains major feature update.
  • [ ] This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • [x] The new code conforms to Qiling Framework naming convention.
  • [x] The imports are arranged properly.
  • [x] Essential comments are added.
  • [ ] The reference of the new code is pointed out.

Extra tests?

  • [x] No extra tests are needed for this PR.
  • [ ] I have added enough tests for this PR.
  • [ ] Tests will be added after some discussion and review.

Changelog?

  • [x] This PR doesn't need to update Changelog.
  • [ ] Changelog will be updated after some proper review.
  • [ ] Changelog has been updated in my PR.

Target branch?

  • [x] The target branch is dev branch.

One last thing


libumem avatar Jul 08 '24 00:07 libumem

Try to adhere to PEP8 conventions, it really helps to keep the code clean and tidy

I've since run a linter to address this.

Use proper annotations also for return values, not only for arguments

Should be fixed now.

Add more comments explaining what you are doing; things that are obvious to you might not be for others

Added multiple comment sections to aid understanding.

I am not sure we are allowed to attach the firmware files here. If you have a direct like to the firmware on the vendor's website, that would be great

Removed firmware file (which was the wrong one anyway) and added a link to the manufacturer's page.

libumem avatar Jul 19 '24 22:07 libumem

Great, thanks for making the changes. Please see the two remaining comments.

(Make sure to tag me, so I will get notified)

elicn avatar Jul 21 '24 10:07 elicn

@elicn Addressed the feedback you gave. Much appreciated.

libumem avatar Jul 21 '24 22:07 libumem

Will someone else please approve this?

libumem avatar Aug 23 '24 22:08 libumem

Hi,

Welcome to Qiling Framework.

Nice work. Thanks!

Sorry for the delay.

xwings avatar Nov 25 '24 01:11 xwings