PathFinding.js icon indicating copy to clipboard operation
PathFinding.js copied to clipboard
verified publisher icon qiao

Linting errors + 'bench' not working on Windows

Open joshq00 opened this issue 11 years ago • 3 comments

  • Added .jshintrc
  • Removed unneeded variables / matched quotes / == to ===
  • benchmark/parse_map.js
    • was trying to split by '\r\n' on Windows. Changed to /\r?\n/
    • instead of calling toString, read file by utf8 encoding

joshq00 avatar Jan 24 '15 21:01 joshq00

Mine is unset. But, either way, the regular expression will work, while the EOL assumes the files have the same line endings your os uses

joshq00 avatar Jan 30 '15 16:01 joshq00

@joshq00 Everything looks fine to me. Thanks for the patch :+1: @qiao Any questions you have or should I go ahead and merge?

imor avatar Feb 02 '15 03:02 imor

?

joshq00 avatar Oct 08 '16 03:10 joshq00