qdrant-helm icon indicating copy to clipboard operation
qdrant-helm copied to clipboard

allow preventing test hooks from being rendered (again)

Open SlowSnowFox opened this issue 1 year ago • 1 comments

Problem: We are using GCP Cloud Deploy to deploy the chart as a dependency to a GKE cluster. Cloud Deploy calls skaffold render, which, in our case, uses Helm to render the manifest. The rendered manifest then gets applied, including the test-db-interaction deployment. Although the test runs successfully and is marked as completed/successful, Cloud Deploy still marks the release as failed since the test pod is not marked as ready.

Potential Suggested Solution: Introduce a conditional render around the test deployment.

Why did I create a new issue? This is essentially the same request as described in issue #77 . That issue was marked as resolved because the test passed, and the deployment tool no longer flagged the release as failed. However, the underlying problem of preventing the test deployment from being rendered still persists.

I'm happy to create a PR for the suggested solution myself—just wanted to confirm that this mechanism would be an acceptable approach before proceeding.

SlowSnowFox avatar Sep 23 '24 20:09 SlowSnowFox

In case anyone is interested in our temporary fix for google cloud deploy:

  1. skipBuildDeps in Skaffold
  2. unpack the qdrant helm chart
  3. delete the tests dir
  4. pack
  5. continue the deploy

SlowSnowFox avatar Sep 23 '24 22:09 SlowSnowFox