qdrant-haystack icon indicating copy to clipboard operation
qdrant-haystack copied to clipboard
verified publisher icon qdrant

refactor: add batch_size to qdrant __init__

Open pandasar13 opened this issue 2 years ago • 0 comments

Pull Request

Description

Add batch_size parameter to init. The batch_size parameter specified in the init of qdrant for the functions get_all_documents(), get_all_documents_generator(), get_documents_by_id(), write_documents() (NOT for update_embeddings) not only ensures that there is consistency with other haystack DocumentStores but also allows to specify the batch_size when initializing the DocumentStore which allows for the use of pipelines in a less constrained manner.

Related Issue

This PR is related to this issue #37

Changes Made

Added batch size to qdrant init method. The functionsget_all_documents(), get_all_documents_generator(), get_documents_by_id(), write_documents()will take the batch_size specified in the init if not specified.

Checklist

  • [x] I have tested the changes locally.
  • [x] I have addressed all the comments from the code review.
  • [x] This pull request follows the coding style of the project.
  • [x] I have assigned the PR to the correct milestone.

Additional Notes

[Add any additional information or context that might be relevant to reviewers.]

pandasar13 avatar Nov 23 '23 18:11 pandasar13