dcr icon indicating copy to clipboard operation
dcr copied to clipboard

refactor(config): remove repeated code in package config

Open qascade opened this issue 2 years ago • 9 comments

Description

While writing the config parser. I had to give in to some level of redundancy for the sake of other high priorities. I want that to be fixed. I want to refactor and refine the config parser and remove unnecessary redundancies.

qascade avatar May 19 '23 22:05 qascade

Assign this to me, I am very much familiar with config files in Go

yuvicc avatar May 20 '23 04:05 yuvicc

Hey, @i-am-yuvi, assigning this to you. Please make sure that you don't change the structures/types of the abstractions defined in the package config. Also this is not a breaking change, so all the parsing tests should pass. Also extend the TestConfig() function to have more stricter checks as per #35

qascade avatar May 21 '23 05:05 qascade

Surely 🚀

yuvicc avatar May 21 '23 05:05 yuvicc

@i-am-yuvi Please name the branch refactor.redundancy_removal_config

qascade avatar May 21 '23 17:05 qascade

Sure

yuvicc avatar May 21 '23 17:05 yuvicc

@i-am-yuvi Any progress on the issue? As per policy, I will have to unassign this issue on 3 days of inactivity.

qascade avatar May 26 '23 15:05 qascade

Yes I am working on it

yuvicc avatar May 26 '23 15:05 yuvicc

Hi @qascade , I am new to GO language, however I want to learn and contribute to this project and would want to work on this Issue. May you guide me in this issue and assign ?

shrey-a-gupta avatar Jun 19 '23 17:06 shrey-a-gupta

@shrey-a-gupta you can email me at [email protected], we will connect of required. Thanks for taking interest in my project.

qascade avatar Jun 19 '23 19:06 qascade