dcr icon indicating copy to clipboard operation
dcr copied to clipboard

fix(config): error message on wrong yaml input.

Open qascade opened this issue 2 years ago • 14 comments

Description

There is a code in the ParseSpec() function that outputs a better error message if there is an error in input yaml but for some reason, the proper error message is not propagating back.

qascade avatar May 04 '23 10:05 qascade

Want to contribute on this issue request to assign me this issue

shraddha761 avatar May 20 '23 09:05 shraddha761

Hey, @shraddha761 thanks for your enthusiasm. Currently no issues are being assigned until GSSoC Mentors are onboarded. That should happen by EOD. Then I will start assigning the issues. You can start looking at the code and the spec docs and try to understand the project in the meanwhile.

qascade avatar May 20 '23 10:05 qascade

Hey, @shraddha761 assigning this issue to you.

qascade avatar May 21 '23 05:05 qascade

image hey @qascade what to change in the following line

shraddha761 avatar May 21 '23 07:05 shraddha761

@shraddha761 To fix this issue, you introduce an error in yaml. Then, you run TestConfig() function. After that the code should return err3 in the above code. That's not happening. Make any necessary changes that do not break any present functionality but gives a proper meaningful error if things go wrong.

qascade avatar May 21 '23 08:05 qascade

@qascade I am not familiar with Go and yml file will you please explain little bit about the changes to be done

shraddha761 avatar May 21 '23 09:05 shraddha761

@shraddha761 Oh no worries, You should probably get familiar with Go and Yaml first. Added a beginners section in GSSoC_Guidelines.md. Please check that out.

qascade avatar May 21 '23 09:05 qascade

The dcr binary runs a folder containing yaml files and runs a service on them. You should try to understand what the project is at a high level before proceeding to change anything. You may understand that after watching my video and reading the spec doc.

qascade avatar May 21 '23 09:05 qascade

Hey @shraddha761, Any progress on the PR?

qascade avatar May 22 '23 05:05 qascade

@qascade I tried to do some changes but didn't get the proper output

shraddha761 avatar May 22 '23 08:05 shraddha761

@shraddha761 Let's continue this on discord.

qascade avatar May 22 '23 08:05 qascade

@qascade Yahh sure

shraddha761 avatar May 22 '23 09:05 shraddha761

Please come by the #dcr channel @shraddha761

qascade avatar May 22 '23 09:05 qascade

This issue has been inactive for a long time Is this resolved? If not, I would like to work on this issue Please assign

sagnik-p avatar Jun 09 '23 19:06 sagnik-p