safety icon indicating copy to clipboard operation
safety copied to clipboard

Enhance Error Messages

Open dylanpulver opened this issue 1 year ago • 6 comments

Clear and informative error messages are essential for a good user experience. We are looking for contributions that improve existing error messages, making them more descriptive and helpful for users. If you improve an error message, please create a new issue to describe the enhancements you’ve made and link it back to this general error message improvement issue.

dylanpulver avatar Aug 14 '24 22:08 dylanpulver

Hi @dylanpulver, thank you for opening this issue!

We appreciate your effort in reporting this. Our team will review it and get back to you soon. If you have any additional details or updates, feel free to add them to this issue.

Note: If this is a serious security issue that could impact the security of Safety CLI users, please email [email protected] immediately.

Thank you for contributing to Safety CLI!

github-actions[bot] avatar Aug 14 '24 22:08 github-actions[bot]

take

rpattekar avatar Aug 14 '24 22:08 rpattekar

@dylanpulver Can someone please point out to me one error message that would be a good candidate for enhancing? Just so I have an idea of what to look for...

rpattekar avatar Aug 15 '24 05:08 rpattekar

Hi @rpattekar, Absolutely!

For this one we welcome updates to existing error messages as well as introducing new error messages to the codebase.

I will post a few approaches here.

  1. searching LOG.exception in the codebase We have 20 results here which can likely be improved upon!: image

  2. searching try We have ~100 try except loops but not all except blocks have logging currently. image

  3. searching LOG.error We have 8 cases of LOG.error in the codebase that could likely be improved! image

These are just starting places/ideas to consider for improving existing logging and adding more logging. We welcome any ideas to improve our error messages across the codebase! Thank you!

dylanpulver avatar Aug 20 '24 19:08 dylanpulver

its a good idea to improve log statements in the code, can you please help me locate the console messages for this?

vgauraha62 avatar Oct 25 '24 14:10 vgauraha62

@vgauraha62 Definitely! In my message above I listed a few areas where log statements either exist or should be added. Is there anything else I can help to provide?

dylanpulver avatar Oct 29 '24 13:10 dylanpulver