pyup icon indicating copy to clipboard operation
pyup copied to clipboard

Fix bad return of hashes

Open bhearsum opened this issue 5 years ago • 2 comments

I might be missing something, but I'm not sure how the code is supposed to work in its current form - when I use debug logging, data quite clearly does not contain hashes, and the block above this pretty clear is meant to built up the hashes that the caller wants.

bhearsum avatar Sep 10 '20 19:09 bhearsum

Codecov Report

Merging #392 into master will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files          11       11           
  Lines        1157     1157           
=======================================
  Hits         1090     1090           
  Misses         67       67           
Impacted Files Coverage Δ
pyup/requirements.py 88.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fb8638...d301812. Read the comment docs.

codecov[bot] avatar Sep 10 '20 19:09 codecov[bot]

If you can do that, it would be great to avoid regressions.

Avoiding regression is great, but in the meantime, the tool is broken. Please consider merging this as-is

cblegare avatar Apr 30 '21 18:04 cblegare