datrie icon indicating copy to clipboard operation
datrie copied to clipboard

Added serializing into `bytes` object

Open KOLANICH opened this issue 6 years ago • 12 comments

This PR requires https://github.com/tlwg/libdatrie/pull/12 to be merged first (or maybe create an own fork of that lib, because that fork is inactive).

KOLANICH avatar Nov 11 '19 18:11 KOLANICH

@kmike, @jdufresne, @cclauss

KOLANICH avatar Nov 15 '19 19:11 KOLANICH

https://gitlab.com/KOLANICH-subgroups/packages/datrie/-/jobs/artifacts/master/raw/wheels/datrie-0.CI_python-py3-none-any.whl?job=build

KOLANICH avatar Nov 15 '19 22:11 KOLANICH

@KOLANICH This requires a re-base.

tacaswell avatar Mar 26 '20 03:03 tacaswell

Thank you, but we are still waiting on the PR (and release?) in libdatrie for this to be mergeable? What commit is the submodule pointing at now?

tacaswell avatar Mar 27 '20 00:03 tacaswell

I have sent there a PR, but when a PR is sent, GH puts the commits into the repo (proof), so submodules should work even if that PR is not merged yet.

KOLANICH avatar Mar 27 '20 00:03 KOLANICH

if the PR gets closed without being merged or you change the PR (either by just adding more commits or by force-pushing new commits) what will make sure the commit we are relying on here does not get "garbage collected" by github?

tacaswell avatar Mar 27 '20 00:03 tacaswell

If it is your concern, you can fork that repo and fetch the branch from mine. I don't want to tie this project to my fork of that repo because I plan to delete it as soon as everything I need merged.

KOLANICH avatar Mar 27 '20 06:03 KOLANICH

The upstream PR still appears to not be merged?

tacaswell avatar Jan 22 '21 17:01 tacaswell

@tacaswell, it's merged into the upstream.

KOLANICH avatar Jan 23 '21 21:01 KOLANICH

@tacaswell

KOLANICH avatar Feb 18 '21 19:02 KOLANICH

@tacaswell

KOLANICH avatar Mar 11 '21 18:03 KOLANICH

@tacaswell

KOLANICH avatar Mar 30 '21 21:03 KOLANICH