hackr icon indicating copy to clipboard operation
hackr copied to clipboard

Restructure generator.py according to the utilities

Open ashwini0529 opened this issue 8 years ago • 6 comments

As of now, there are multiple functionalities implemented in a single file. Most of the generator functions are Faker oriented. Maybe a separate file handles such functions.

ashwini0529 avatar Oct 01 '17 23:10 ashwini0529

Just had a look at this. You want the functions using Faker to be separated from the few that don't?

theycallmemac avatar Oct 01 '17 23:10 theycallmemac

Yeah basically the purpose of generator is to generate data. Now that maybe using Faker, built-in functions, or any other way. generator.py should be in such a way, that it should not contain much of a repeated code, or functions.

ashwini0529 avatar Oct 01 '17 23:10 ashwini0529

So rather than having separate files handling such functions as you've said above, this is just a refactoring issue?

theycallmemac avatar Oct 01 '17 23:10 theycallmemac

Yeah kind of refactoring issue.

ashwini0529 avatar Oct 01 '17 23:10 ashwini0529

Hey @theycallmemac , can you please check a comment that I made on your PR? That would be ready to merge then. 🎉

ashwini0529 avatar Oct 03 '17 14:10 ashwini0529

Isn't it merged already?

theycallmemac avatar Oct 03 '17 14:10 theycallmemac