hackr icon indicating copy to clipboard operation
hackr copied to clipboard

Complete usage of Faker in generator.py

Open ashwini0529 opened this issue 8 years ago • 6 comments

Right now it generates name and addresses using Faker. Faker could be utilised completely to add more functionalities.

ashwini0529 avatar Oct 01 '17 21:10 ashwini0529

I want to fix this issue 😄

vaibhavsingh97 avatar Oct 01 '17 22:10 vaibhavsingh97

How about some networking to get it going? https://github.com/pytorn/hackr/pull/7.

It might be beneficial to restructure a little, as all of faker implemented in 1 file could be a bit of a mess...

willBoyd8 avatar Oct 01 '17 22:10 willBoyd8

It would be great. @willBoyd8 if you restructure all Faker implementations in one file and use it in generators. 😄

ashwini0529 avatar Oct 01 '17 22:10 ashwini0529

See if https://github.com/pytorn/hackr/pull/13 is what you'd like... That also makes it easy for others ( @vaibhavsingh97 ) to add other functionality too. The month of hacktober is still young... ;)

willBoyd8 avatar Oct 02 '17 04:10 willBoyd8

Hey, @willBoyd8 can you please check a comment that I made on your PR? That would be ready to merge then. 🎉

ashwini0529 avatar Oct 03 '17 14:10 ashwini0529

Yeah sorry. I'm a little slow on weekdays

willBoyd8 avatar Oct 03 '17 15:10 willBoyd8