vision icon indicating copy to clipboard operation
vision copied to clipboard

Remove deprecated APIs for 0.14

Open NicolasHug opened this issue 3 years ago • 4 comments

Closes https://github.com/pytorch/vision/issues/6257

git grep -n "0\.14" torchvision/ now gives zero output

NicolasHug avatar Jul 11 '22 13:07 NicolasHug

@datumbox following up on https://github.com/pytorch/vision/pull/6258#discussion_r928926367 about the C++ models: if that works for you, I'll remove them in another PR. The only reason is that I fear that removing them might break some stuff internally. I'd rather isolate that in a separate PR, to avoid having to potentially revert other unrelated changes (like the rest of the deprecations).

NicolasHug avatar Jul 28 '22 09:07 NicolasHug

@kazhang thanks for pointing out that _transforms_video.py is still referred internally so we need to discuss a plan for deprecating this particular file.

jdsgomes avatar Aug 03 '22 16:08 jdsgomes

Thanks @jdsgomes . I opened D38393214 to see what tests might break if we removed these files.

NicolasHug avatar Aug 03 '22 17:08 NicolasHug

@NicolasHug I don't have a super strong opinion about splitting the PRs if that simplifies your work. Curious why you think this can cause issues on FBcode though. As far as I see we don't even compile these sources on BUCK, so I don't see how people are using them. Have you saw anything different? If not, you can add the removal here; otherwise send a separate PR that removes the endpoints in question as you proposed.

Happy to provide the necessary stamps once you confirm things work on FBcode + the tests pass.

datumbox avatar Aug 04 '22 09:08 datumbox

@NicolasHug @datumbox @jdsgomes Could you check if this PR is okay to merge? I think regarding the removal of deprecated API, other than this PR only the following two things left:

  • Removal of cpp models: https://github.com/pytorch/vision/pull/6632
  • To be discussed whether or not we remove transforms/_functional_video.py and transforms/_transforms_video.py but we agree this will be on separate PR

I have checked and everything seems fine to me on this PR and I prefer if we can merge this PR faster and do fbsync in case anything we need to revert.

YosuaMichael avatar Sep 26 '22 13:09 YosuaMichael

@NicolasHug do you prefer to do this on a new PR so that the attribution is right?

Just FYI, the changes in this PR come from my commits.

But whether this PR gets merged or another makes no difference to me.

NicolasHug avatar Sep 26 '22 13:09 NicolasHug

Just to update, I found 2 breakages internally after trying this changes. I have created diffs to fix for each of them, and I will merge this PR once the fix is landed.

  1. Break due to Kinetics400 removal: D39832659
  2. Break due removal of resample and fillcolor argument on RandomAffine: D39843275

YosuaMichael avatar Sep 27 '22 13:09 YosuaMichael

The failed test seems to be not related to this PR, will merge

YosuaMichael avatar Sep 28 '22 13:09 YosuaMichael

Hey @YosuaMichael!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

github-actions[bot] avatar Sep 28 '22 13:09 github-actions[bot]