tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

varlen attention tutorial

Open liangel-02 opened this issue 2 months ago • 8 comments

This PR is a tutorial for a variable length attention API

liangel-02 avatar Nov 24 '25 19:11 liangel-02

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3660

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit af7fe97f790eb542ff77b6bab62df3bab216d87b with merge base 63e3575c8b077fb8eded4348ccdb41b0e9bc965b (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Nov 24 '25 19:11 pytorch-bot[bot]

@svekars any tips for reviewing this code in a more human friendly way?

drisspg avatar Nov 25 '25 01:11 drisspg

There is more info here: https://github.com/pytorch/tutorials#contributing and there is a script that will help you convert your .ipynb to .py

svekars avatar Dec 01 '25 21:12 svekars

There is also an error here: https://github.com/pytorch/tutorials/actions/runs/19864783846/job/56924391840?pr=3660#step:9:4582 - let me check how should we test against 2.10.

svekars avatar Dec 02 '25 17:12 svekars

@AlannaBurke can you please review this 2.10 tutorial.

svekars avatar Jan 05 '26 20:01 svekars

Nightly preview: https://docs-preview.pytorch.org/pytorch/tutorials-nightly-preview/3660/intermediate/variable_length_attention_tutorial.html

svekars avatar Jan 06 '26 22:01 svekars

looks great, make sure you've resolved all of @svekars 's comments

AlannaBurke avatar Jan 15 '26 21:01 AlannaBurke

looks great, make sure you've resolved all of @svekars 's comments

yep resolved

liangel-02 avatar Jan 15 '26 22:01 liangel-02