torchx icon indicating copy to clipboard operation
torchx copied to clipboard

Update dev-requirements.txt pyre-extensions

Open ntlm1686 opened this issue 3 years ago • 2 comments

I was unable to run any pyre command with pyre-extensions==0.0.21, but when I upgrade to 0.0.29, it works. Dependencies are installed with pip install -e '.[dev]'.

When use pyre It throws the error below on both macos and linux:

Traceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniforge/base/envs/torchx-dev/bin/pyre", line 5, in <module>
    from pyre_check.client.pyre import main
  File "/opt/homebrew/Caskroom/miniforge/base/envs/torchx-dev/lib/python3.8/site-packages/pyre_check/client/pyre.py", line 19, in <module>
    from . import (
  File "/opt/homebrew/Caskroom/miniforge/base/envs/torchx-dev/lib/python3.8/site-packages/pyre_check/client/commands/__init__.py", line 6, in <module>
    from . import (  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401  # noqa F401
  File "/opt/homebrew/Caskroom/miniforge/base/envs/torchx-dev/lib/python3.8/site-packages/pyre_check/client/commands/persistent.py", line 43, in <module>
    from . import (
  File "/opt/homebrew/Caskroom/miniforge/base/envs/torchx-dev/lib/python3.8/site-packages/pyre_check/client/commands/language_server_protocol.py", line 15, in <module>
    from pyre_extensions import override
ImportError: cannot import name 'override' from 'pyre_extensions' (/opt/homebrew/Caskroom/miniforge/base/envs/torchx-dev/lib/python3.8/site-packages/pyre_extensions/__init__.py)

Test plan:

ntlm1686 avatar Sep 02 '22 00:09 ntlm1686

Codecov Report

Merging #596 (6d473ab) into main (d25bdc1) will decrease coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   92.54%   92.50%   -0.04%     
==========================================
  Files          86       86              
  Lines        5740     5740              
==========================================
- Hits         5312     5310       -2     
- Misses        428      430       +2     

see 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 02 '22 01:09 codecov[bot]

@d4l3k #587

ntlm1686 avatar Sep 02 '22 01:09 ntlm1686