torch.x -- document dict argument parsing failure case when value contains "="
Summary: in some cases, the value can contain "=". For example, some base64 encoded values as environment variable. torch.x parser currently does not support this case.
adding a test to capture this failure. wonder if we should consider support this. An example use case can be parsing temp AWS token credential to ddp
also correct a documentation copy-pasta
Reviewed By: kiukchung
Differential Revision: D35560931
This pull request was exported from Phabricator. Differential Revision: D35560931
Codecov Report
Merging #469 (16433f0) into main (05a7a8b) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #469 +/- ##
=======================================
Coverage 94.61% 94.61%
=======================================
Files 65 65
Lines 3862 3862
=======================================
Hits 3654 3654
Misses 208 208
| Impacted Files | Coverage Δ | |
|---|---|---|
| torchx/schedulers/docker_scheduler.py | 95.81% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 05a7a8b...16433f0. Read the comment docs.