torchx icon indicating copy to clipboard operation
torchx copied to clipboard

Use Meta networking lib (#75894)

Open aivanou opened this issue 3 years ago • 4 comments

Summary: X-link: https://github.com/pytorch/pytorch/pull/75894

Move get_host_addr to separate module, and implement meta-internal get_host_addr that uses meta networking lib.

More info: https://docs.google.com/document/d/1paDoXWOy1ws2i1riFypJ3hpP6rO7cPwzTAHnH8OkPKY

Reviewed By: kiukchung, Babar

Differential Revision: D35288985

aivanou avatar Apr 15 '22 19:04 aivanou

Hi @aivanou!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Apr 15 '22 19:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D35288985

facebook-github-bot avatar Apr 15 '22 19:04 facebook-github-bot

Codecov Report

Merging #462 (d3efb89) into main (37c76eb) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          65       65           
  Lines        3833     3833           
=======================================
  Hits         3626     3626           
  Misses        207      207           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37c76eb...d3efb89. Read the comment docs.

codecov[bot] avatar Apr 15 '22 19:04 codecov[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Apr 15 '22 20:04 facebook-github-bot