torchx icon indicating copy to clipboard operation
torchx copied to clipboard

add monarch app def to use monarchs torchrun

Open colin2328 opened this issue 3 months ago • 2 comments

Summary: RFC diff to use monarch's torchrun runner .

creates an app def that

Differential Revision: D86155019

colin2328 avatar Nov 04 '25 01:11 colin2328

@colin2328 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86155019.

meta-codesync[bot] avatar Nov 04 '25 01:11 meta-codesync[bot]

Codecov Report

:x: Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 91.34%. Comparing base (dd683f4) to head (ce80778).

Files with missing lines Patch % Lines
torchx/components/dist.py 4.54% 21 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
- Coverage   91.63%   91.34%   -0.29%     
==========================================
  Files          84       84              
  Lines        6595     6617      +22     
==========================================
+ Hits         6043     6044       +1     
- Misses        552      573      +21     
Flag Coverage Δ
unittests 91.34% <4.54%> (-0.29%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Nov 04 '25 01:11 codecov-commenter