pytorch
Fix Gemma inference generation
Context
Running generate.py for Gemma 2B gives the following error: File "torchtune/modules/kv_cache.py", line 47, in update assert input_pos.shape[0] == k_val.shape[2] AttributeError: 'NoneType' object has no attribute 'shape'
Changelog
Re-add input_pos to modules/gemma/transformer.py to match the base transformer.py
This allows the config to successfully generate text.
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/810
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
:white_check_mark: No Failures
As of commit 0a12cbe2cca576524b7da4605c030403737c1431 with merge base 41341fd1df326c0f6665c4e0a79965c3a7e8d836 (
This comment was automatically generated by Dr. CI and updates every 15 minutes.
![pytorch-bot[bot] avatar](https://avatars.githubusercontent.com/in/40112?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @Carolinabanana!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Awesome catch, thanks for fixing this! Do you mind signing the CLA? Then I'm happy to merge this in for you
Done