tnt
tnt copied to clipboard
Set default value for max_steps in _is_epoch_done util
Summary:
In evaluate and predict the user does not pass in a max_steps argument so it may seem strange that state.max_steps is used here: https://github.com/pytorch/tnt/blob/master/torchtnt/framework/evaluate.py#L143
Removing this for better readability
Differential Revision: D48198032
This pull request was exported from Phabricator. Differential Revision: D48198032
Codecov Report
Merging #497 (e052e88) into master (5150591) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## master #497 +/- ##
=======================================
Coverage 86.91% 86.91%
=======================================
Files 102 102
Lines 8337 8337
=======================================
Hits 7246 7246
Misses 1091 1091
| Files Changed | Coverage Δ | |
|---|---|---|
| torchtnt/framework/evaluate.py | 92.06% <ø> (ø) |
|
| torchtnt/framework/predict.py | 90.76% <ø> (ø) |
|
| torchtnt/framework/utils.py | 87.83% <ø> (ø) |
|
| tests/framework/test_utils.py | 77.05% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more